Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum viewport size for Stage Two documents #309

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

victorc-bcgov
Copy link
Collaborator

Preliminary fix for DF-2859 that sets the "minSize" CSS attribute to ensure that the browser's canvas meets a minimum viable threshold to produce a high-quality SVG for conversion into PDF. Additional tweaks made to snip off the blank parts of SVGs so that the PDFs will better fit onto US Letter 8.5" x 11" paper.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

rsbc-roadside-forms-frontend:latest (redhat 8.7) - Trivy Report - 2024-03-26 20:51:17.488634828 +0000 UTC m=+0.192789544

redhat
No Vulnerabilities found
No Misconfigurations found

Copy link
Contributor

@amlanc1 amlanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@amlanc1 amlanc1 merged commit 47c3716 into release/2024.3.3 Mar 27, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants