Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF-1758 : DF Error Code and moved the model file to common folder #377

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

ratheesh-aot
Copy link
Contributor

@ratheesh-aot ratheesh-aot commented Sep 23, 2024

Issue#: https://jag.gov.bc.ca/jirarsi/browse/DF-1758

Created error model and table in Digital forms to track errors
Defined basic error code enums (only in python side, in db its all string fields for better filtering capabilities)
Integrated code for recording error to DF Error table
Updated all three services: prohibition, form_handler and task scheduler

Moved the model file to common folder and changed the import of all the three services to use it form common
previously the replace all the three seperate dupicate copy of model with the updated model in prohibition svc
Updated the docker files

Sample error
image
image
image

Unit test added to test the error handling part
https://github.com/bcgov/rsbc-digital-forms/blob/5853654d734b8fa17db1e144263b6886986552c2/python/common/tests/record_error/test_record_error.py

@ratheesh-aot ratheesh-aot changed the title DF-1758 : DF Error Code and Model Restructure DF-1758 : DF Error Code and moved the model file to common folder Sep 23, 2024
Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-23 23:35:33.657045224 +0000 UTC m=+0.329827775

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-23 23:35:50.441901963 +0000 UTC m=+0.354318503

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-23 23:36:02.830075324 +0000 UTC m=+0.354184535

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-24 16:48:18.866931878 +0000 UTC m=+0.364991352

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-24 16:55:33.50214586 +0000 UTC m=+0.378446661

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-24 16:55:36.286716859 +0000 UTC m=+0.351866597

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-24 17:05:13.407269371 +0000 UTC m=+0.333968654

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-24 17:05:25.757238115 +0000 UTC m=+0.343351661

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-24 17:13:07.75353545 +0000 UTC m=+0.347161166

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-25 17:01:03.775837104 +0000 UTC m=+0.324934714

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-25 17:01:15.833014855 +0000 UTC m=+0.335778982

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-25 17:04:22.454791029 +0000 UTC m=+0.333885102

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-26 00:24:49.038772279 +0000 UTC m=+0.333935417

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-26 00:25:15.291708889 +0000 UTC m=+0.351714533

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-26 00:33:32.708197938 +0000 UTC m=+0.369333388

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-26 17:29:21.508997643 +0000 UTC m=+0.342315276

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-26 17:29:44.08004818 +0000 UTC m=+0.360310408

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-26 17:43:37.183461193 +0000 UTC m=+0.336736196

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-26 19:01:54.559071537 +0000 UTC m=+0.336021132

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-26 19:02:02.574412055 +0000 UTC m=+0.359684446

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-26 19:02:11.172534203 +0000 UTC m=+0.337370663

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@adimar-aot adimar-aot merged commit ab4a45a into release/2024.10.1 Oct 1, 2024
10 of 11 checks passed
@adimar-aot adimar-aot deleted the fix/CommonModelTable branch October 1, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants