Small comment notes and rearrangements

bcgov · May 6, 2024 · dace4ab · dace4ab
1 parent 594d84a
commit dace4ab
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/auth-api/src/auth_api/config.py b/auth-api/src/auth_api/config.py
@@ -135,7 +135,7 @@ class _Config:  # pylint: disable=too-few-public-methods
     LEAR_AFFILIATION_DETAILS_URL = f'{LEGAL_API_URL + LEGAL_API_VERSION_2}/businesses/search'
     NAMEX_AFFILIATION_DETAILS_URL = f'{NAMEX_API_URL}/requests/search'
 
-    # PUB/SUB
+    # PUB/SUB - PUB: account-mailer-dev, auth-event-dev
     GCP_AUTH_KEY = os.getenv('GCP_AUTH_KEY', None)
     ACCOUNT_MAILER_TOPIC = os.getenv('ACCOUNT_MAILER_TOPIC', 'account-mailer-dev')
     AUTH_EVENT_TOPIC = os.getenv('AUTH_EVENT_TOPIC', 'auth-event-dev')

diff --git a/queue_services/account-mailer/src/account_mailer/config.py b/queue_services/account-mailer/src/account_mailer/config.py
@@ -95,8 +95,8 @@ class _Config():  # pylint: disable=too-few-public-methods
     NOTIFY_API_URL = os.getenv('NOTIFY_API_URL')
     REPORT_API_BASE_URL = f'{os.getenv("REPORT_API_URL")}/reports'
 
-    # PUB/SUB
-    # SUBSCRIBES TO THIS TOPIC: account-mailer-dev
+    # PUB/SUB - SUB: account-mailer-dev
+    # If blank in PUB/SUB, this should match the https endpoint the subscription is pushing to.
     AUTH_SUB_AUDIENCE = os.getenv('AUTH_SUB_AUDIENCE')
     VERIFY_PUBSUB_EMAILS = os.getenv('VERIFY_PUBSUB_EMAILS', 'email1,email2').split(',')
 

diff --git a/queue_services/auth-queue/src/auth_queue/config.py b/queue_services/auth-queue/src/auth_queue/config.py
@@ -74,13 +74,13 @@ class _Config:  # pylint: disable=too-few-public-methods
     DB_PORT = os.getenv('DATABASE_PORT', '5432')
     SQLALCHEMY_DATABASE_URI = f'postgresql://{DB_USER}:{DB_PASSWORD}@{DB_HOST}:{int(DB_PORT)}/{DB_NAME}'
 
-    # PUB/SUB
-    # SUBSCRIBES TO THESE TOPICS: auth-event-dev and namex-nr-state-dev
-    GCP_AUTH_KEY = os.getenv('GCP_AUTH_KEY', None)
+    # PUB/SUB - PUB: account-mailer-dev, SUB: auth-event-dev and namex-nr-state-dev
+    ACCOUNT_MAILER_TOPIC = os.getenv('ACCOUNT_MAILER_TOPIC', 'account-mailer-dev')
     AUTH_SUB_AUDIENCE = os.getenv('AUTH_SUB_AUDIENCE')
+    GCP_AUTH_KEY = os.getenv('GCP_AUTH_KEY', None)
+    # If blank in PUB/SUB, this should match the https endpoint the subscription is pushing to.
     VERIFY_PUBSUB_EMAILS = os.getenv('VERIFY_PUBSUB_EMAILS', 'email1,email2').split(',')
-    ACCOUNT_MAILER_TOPIC = os.getenv('ACCOUNT_MAILER_TOPIC', 'account-mailer-dev')
-
+
     PAY_API_URL = os.getenv('PAY_API_URL') + os.getenv('PAY_API_VERSION')
 
     # Service account details