18522, 18525 - updates to REQUEST affiliation #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfekete
requested review from
Jxio,
seeker25,
ochiu and
rodrigo-barraza
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
==========================================
+ Coverage 80.71% 89.50% +8.78%
==========================================
Files 322 178 -144
Lines 11915 9421 -2494
Branches 618 48 -570
==========================================
- Hits 9617 8432 -1185
+ Misses 2289 977 -1312
- Partials 9 12 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ochiu
reviewed
Nov 21, 2023
…ing org details for affiliated orgs.
|
Kudos, SonarCloud Quality Gate passed!
|
ochiu
approved these changes
Nov 21, 2023
seeker25
reviewed
Nov 21, 2023
| @@ -158,12 +159,19 @@ def search_org(cls, search: OrgSearch, environment: str): | |||
| return pagination.items, pagination.total | |||
|
|
|||
| @classmethod | |||
| def search_orgs_by_business_identifier(cls, business_identifier, pagination_info: PaginationInfo, environment): | |||
| def search_orgs_by_business_identifier(cls, | |||
There was a problem hiding this comment.
Alotta params, would have combined pagination_info, excluded_org_types together - they both affect the query
But this should be ok, environment we'll eventually gun anyways
seeker25
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:18522 bcgov/entity#18522
Issue #:18525 bcgov/entity#18525
Description of changes:
Updates to REQUEST affiliation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).