19331 & 19330 - Unlinked + Linked Short Name Mapping tables #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will re-open as we get this more complete (so CI doesn't just burn up cycles) |
This reverts commit 1d35c4d.
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2700-zy7q0oum.web.app |
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-2700-zy7q0oum.web.app |
Jxio
reviewed
Feb 5, 2024
Jxio
approved these changes
Feb 5, 2024
seeker25
commented
Feb 5, 2024
| state.visibleItems = state.sortedItems.slice(0, perPage.value) | ||
| firstItem.value = state.visibleItems[0] | ||
| currentPage.value = 1 | ||
| reachedEnd.value = false | ||
| scrollToTop() | ||
| } | ||
| if (props.observerCallback) { |
There was a problem hiding this comment.
Will combine this with 225 in the future, probably return function, so it doesn't need to check for props.observerCallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#19330
bcgov/entity#19331
Description of changes:
Short Name Mapping tables
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).