Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20732 - Queue fixes #2828

Merged
merged 29 commits into from
May 21, 2024
Merged

20732 - Queue fixes #2828

merged 29 commits into from
May 21, 2024

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented May 15, 2024

auth-api/Makefile Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.31%. Comparing base (261dc17) to head (34f6f29).
Report is 311 commits behind head on main.

Current head 34f6f29 differs from pull request most recent head 562bfe3

Please upload reports for the commit 562bfe3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
+ Coverage   80.71%   89.31%   +8.60%     
==========================================
  Files         322      168     -154     
  Lines       11915     9060    -2855     
  Branches      618        0     -618     
==========================================
- Hits         9617     8092    -1525     
+ Misses       2289      968    -1321     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.31% <73.68%> (-0.65%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
auth-api/src/auth_api/models/__init__.py 100.00% <100.00%> (ø)
...i/src/auth_api/models/pubsub_message_processing.py 92.85% <92.85%> (ø)
...h-api/src/auth_api/services/gcp_queue/gcp_queue.py 50.64% <0.00%> (ø)
auth-api/src/auth_api/services/membership.py 71.20% <0.00%> (-0.08%) ⬇️

... and 170 files with indirect coverage changes

@seeker25 seeker25 changed the title Queue fixes - WIP 20732 - Queue fixes - WIP May 16, 2024
@seeker25 seeker25 marked this pull request as ready for review May 16, 2024 21:17
@seeker25 seeker25 changed the title 20732 - Queue fixes - WIP 20732 - Queue fixes May 21, 2024
@seeker25 seeker25 merged commit 7f88114 into main May 21, 2024
12 of 13 checks passed
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seeker25 seeker25 deleted the queue_fixess branch October 24, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants