12383 - Upgrade Node version. #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritvick
approved these changes
Jun 15, 2022
shabeeb-aot
reviewed
Jun 15, 2022
|
@shabeeb-aot has suggested we side line this for now, until his recent changes go through for account-switch and logon / logoff. |
seeker25
force-pushed
the
feature/update_npm
branch
from
dfa5e76
to
5f7852e
Compare
shabeeb-aot
reviewed
Jul 14, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "sbc-common-components", | |||
| "version": "2.4.54", | |||
| "version": "2.5.0", | |||
There was a problem hiding this comment.
since it's a node update I suggest starting with a major version update. maybe 3.0.0
shabeeb-aot
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#12383
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).