Logging changes part3 (#1745)

bcgov · Sep 12, 2024 · 9c8368c · 9c8368c
1 parent 96cfc24
commit 9c8368c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/jobs/payment-jobs/poetry.lock b/jobs/payment-jobs/poetry.lock
diff --git a/jobs/payment-jobs/pyproject.toml b/jobs/payment-jobs/pyproject.toml
@@ -7,7 +7,7 @@ readme = "README.md"
 
 [tool.poetry.dependencies]
 python = "^3.12"
-pay-api = {git = "https://github.com/seeker25/sbc-pay.git", branch = "fix_logging_404_etc", subdirectory = "pay-api"}
+pay-api = {git = "https://github.com/seeker25/sbc-pay.git", branch = "logging_changes_part3", subdirectory = "pay-api"}
 flask = "^3.0.2"
 flask-sqlalchemy = "^3.1.1"
 sqlalchemy = "^2.0.28"

diff --git a/pay-api/src/pay_api/services/oauth_service.py b/pay-api/src/pay_api/services/oauth_service.py
@@ -74,7 +74,7 @@ def post(endpoint, token, auth_header_type: AuthHeaderType,  # pylint: disable=t
             raise ServiceUnavailableException(exc) from exc
         except HTTPError as exc:
             current_app.logger.error(
-                f"HTTPError on POST with status code {exc.response.status_code if exc.response else ''}")
+                f"HTTPError on POST with status code {exc.response.status_code if exc.response is not None else ''}")
             if exc.response and exc.response.status_code >= 500:
                 raise ServiceUnavailableException(exc) from exc
             raise exc
@@ -123,9 +123,9 @@ def get(endpoint, token, auth_header_type: AuthHeaderType,  # pylint:disable=too
             current_app.logger.error(exc)
             raise ServiceUnavailableException(exc) from exc
         except HTTPError as exc:
-            if not exc.response or exc.response.status_code != 404:
+            if exc.response is None or exc.response.status_code != 404:
                 current_app.logger.error('HTTPError on GET with status code '
-                                         f"{exc.response.status_code if exc.response else ''}")
+                                         f"{exc.response.status_code if exc.response is not None else ''}")
             if exc.response is not None:
                 if exc.response.status_code >= 500:
                     raise ServiceUnavailableException(exc) from exc