Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in developer notes #1138

Merged
merged 18 commits into from
Mar 15, 2023
Merged

Adding in developer notes #1138

merged 18 commits into from
Mar 15, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Mar 7, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 added the documentation documentation changes label Mar 7, 2023
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

DEVELOPER_NOTES.md Show resolved Hide resolved
DEVELOPER_NOTES.md Show resolved Hide resolved

6. What is disbursement?

It's the terminology we use to pay our partners. For example there is EJV disbursement for Ministry partners, we have AP Disbursement (EFT) for Non-Ministry Partners. We debit our internal GL (excluding service fees) and credit an external GL or bank account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a diagram to link to here, or embed a mermaid / md one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be, Louise is working on all of the payment diagrams

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@seeker25
Copy link
Collaborator Author

I've added a bit more regarding EJV / PAD payments stuck in APPROVED. Will continue to add to this file weekly.

@seeker25 seeker25 merged commit ca942e6 into main Mar 15, 2023
@seeker25 seeker25 deleted the seeker25-patch-1 branch March 28, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants