Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in db.session.flush() #1139

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add in db.session.flush() #1139

merged 1 commit into from
Mar 7, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Mar 7, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1139 (8aef505) into main (28ff797) will increase coverage by 0.03%.
The diff coverage is 90.08%.

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
+ Coverage   91.54%   91.58%   +0.03%     
==========================================
  Files         153      153              
  Lines        9842     9942     +100     
==========================================
+ Hits         9010     9105      +95     
- Misses        832      837       +5     
Flag Coverage Δ
paymentjobs 80.06% <90.08%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.09% <0.00%> (-0.43%) ⬇️
pay-api/src/pay_api/models/__init__.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/invoice.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/payment.py 96.26% <ø> (ø)
pay-api/src/pay_api/models/payment_account.py 96.96% <ø> (ø)
pay-api/src/pay_api/models/payment_line_item.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/statement.py 97.29% <ø> (-0.14%) ⬇️
pay-api/src/pay_api/resources/account.py 93.18% <ø> (-0.27%) ⬇️
...ay-api/src/pay_api/services/base_payment_system.py 96.47% <ø> (-0.03%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 94.93% <ø> (+6.70%) ⬆️
... and 16 more

@seeker25 seeker25 added the bug Something isn't working label Mar 7, 2023
@seeker25 seeker25 merged commit 58a34cc into main Mar 7, 2023
@seeker25 seeker25 deleted the minor_fix branch March 28, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants