Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15961 - Add in fallback value for cfs_account if the user changes from PAD ->… #1158

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

seeker25
Copy link
Collaborator

… BCOL.

Issue #:
bcgov/entity#15961

Description of changes:
Fall back to INACTIVE CFS account

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested review from Jxio and kialj876 as code owners April 14, 2023 19:03
@seeker25 seeker25 added the bug Something isn't working label Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1158 (4928407) into main (28ff797) will increase coverage by 2.36%.
The diff coverage is 91.74%.

@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
+ Coverage   91.54%   93.90%   +2.36%     
==========================================
  Files         153      128      -25     
  Lines        9842     8520    -1322     
==========================================
- Hits         9010     8001    -1009     
+ Misses        832      519     -313     
Flag Coverage Δ
eventlistenerqueue ?
payapi 93.90% <91.74%> (+<0.01%) ⬆️
paymentjobs ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/services/fee_schedule.py 99.53% <ø> (-0.01%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 86.00% <60.00%> (-2.24%) ⬇️
pay-api/src/pay_api/resources/account.py 92.47% <80.00%> (-0.97%) ⬇️
pay-api/src/pay_api/models/payment.py 95.87% <83.33%> (-0.40%) ⬇️
pay-api/src/pay_api/utils/util.py 91.53% <83.33%> (ø)
...ay-api/src/pay_api/services/base_payment_system.py 95.94% <85.71%> (-0.56%) ⬇️
pay-api/src/pay_api/services/invoice.py 96.79% <90.90%> (-0.23%) ⬇️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/account_fee.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/cas_settlement.py 100.00% <100.00%> (ø)
... and 42 more

... and 31 files with indirect coverage changes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 73b82dc into bcgov:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants