Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial of the new queue service #1185

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

thorwolpert
Copy link
Collaborator

@thorwolpert thorwolpert commented May 24, 2023

Issue #: /bcgov/entity#16405

Description of changes:
Partial add of the new alternate queue. Backed off some changes and the simple cloudevent for the older version of python.
This takes care of Step1 - add minimal publish to sbc-pay

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@thorwolpert thorwolpert requested review from seeker25 and removed request for seeker25 and Jxio May 24, 2023 01:26
@thorwolpert
Copy link
Collaborator Author

Code Qual: I'm leaving the broad Exceptions to be replaced by the Q lib when we can move to a newer version of Python

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1185 (d4b4d3f) into main (28ff797) will increase coverage by 2.25%.
The diff coverage is 88.80%.

@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
+ Coverage   91.54%   93.79%   +2.25%     
==========================================
  Files         153      129      -24     
  Lines        9842     8561    -1281     
==========================================
- Hits         9010     8030     -980     
+ Misses        832      531     -301     
Flag Coverage Δ
eventlistenerqueue ?
payapi 93.79% <88.80%> (-0.11%) ⬇️
paymentjobs ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/services/fee_schedule.py 99.53% <ø> (-0.01%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 86.13% <60.00%> (-2.10%) ⬇️
...ay-api/src/pay_api/services/gcp_queue_publisher.py 64.70% <64.70%> (ø)
pay-api/src/pay_api/resources/account.py 92.47% <80.00%> (-0.97%) ⬇️
pay-api/src/pay_api/models/payment.py 95.87% <83.33%> (-0.40%) ⬇️
...ay-api/src/pay_api/services/base_payment_system.py 95.94% <85.71%> (-0.56%) ⬇️
pay-api/src/pay_api/services/invoice.py 96.79% <90.90%> (-0.23%) ⬇️
pay-api/src/pay_api/utils/util.py 91.47% <90.90%> (-0.07%) ⬇️
pay-api/src/pay_api/config.py 99.34% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
... and 45 more

... and 31 files with indirect coverage changes

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but might want to verify my comment above if you haven't already

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thorwolpert thorwolpert merged commit 4e31083 into bcgov:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants