Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16789 - Change _get_payment_account, so it doesn't fail when there are multip… #1201

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

seeker25
Copy link
Collaborator

…le rows with the same PaymentAccount.id.

Issue #:
bcgov/entity#16789

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested review from Jxio and kialj876 as code owners June 20, 2023 17:49
@seeker25 seeker25 added the bug Something isn't working label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1201 (bedac17) into main (28ff797) will increase coverage by 0.10%.
The diff coverage is 98.36%.

❗ Current head bedac17 differs from pull request most recent head cfe78b1. Consider uploading reports for the commit cfe78b1 to get more accurate results

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
+ Coverage   91.54%   91.64%   +0.10%     
==========================================
  Files         153        9     -144     
  Lines        9842      826    -9016     
==========================================
- Hits         9010      757    -8253     
+ Misses        832       69     -763     
Flag Coverage Δ
eventlistenerqueue ?
payapi ?
paymentjobs ?
paymentreconciliationsqueue 91.64% <98.36%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ons/src/reconciliations/payment_reconciliations.py 91.60% <88.88%> (ø)
...iations/src/reconciliations/cgi_reconciliations.py 93.35% <100.00%> (ø)

... and 159 files with indirect coverage changes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 3cc3fc5 into bcgov:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants