Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16843 - Add in condition to not create NSF invoices if the account is already… #1202

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Jun 22, 2023

… in NSF.

Issue #:
bcgov/entity#16843

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested review from Jxio and kialj876 as code owners June 22, 2023 13:28
@seeker25 seeker25 changed the title Add in condition to not create NSF invoices if the account is already… 16843 - Add in condition to not create NSF invoices if the account is already… Jun 22, 2023
@seeker25 seeker25 added the bug Something isn't working label Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1202 (7a085db) into main (28ff797) will decrease coverage by 0.11%.
The diff coverage is 95.38%.

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   91.54%   91.44%   -0.11%     
==========================================
  Files         153        9     -144     
  Lines        9842      830    -9012     
==========================================
- Hits         9010      759    -8251     
+ Misses        832       71     -761     
Flag Coverage Δ
eventlistenerqueue ?
payapi ?
paymentjobs ?
paymentreconciliationsqueue 91.44% <95.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ons/src/reconciliations/payment_reconciliations.py 91.16% <76.92%> (ø)
...iations/src/reconciliations/cgi_reconciliations.py 93.35% <100.00%> (ø)

... and 159 files with indirect coverage changes

@seeker25 seeker25 temporarily deployed to dev June 22, 2023 13:52 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 2a9e066 into bcgov:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants