Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5857 - Add in new eft_instructions. #1257

Merged
merged 1 commit into from
Sep 28, 2023
Merged

5857 - Add in new eft_instructions. #1257

merged 1 commit into from
Sep 28, 2023

Conversation

seeker25
Copy link
Collaborator

Issue #:
bcgov/entity#5857

Description of changes:
Add in new eft_instructions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25
Copy link
Collaborator Author

Still might require a few text changes after confirmation with the business.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1257 (3d563c9) into main (79924ce) will decrease coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
- Coverage   91.45%   91.45%   -0.01%     
==========================================
  Files         186      177       -9     
  Lines       11319    10484     -835     
==========================================
- Hits        10352     9588     -764     
+ Misses        967      896      -71     
Flag Coverage Δ
paymentreconciliationsqueue ?
reportapi 91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/models/invoice.py 100.00% <ø> (ø)
...api/src/pay_api/resources/v1/account_statements.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/statement.py 96.87% <ø> (-0.04%) ⬇️
pay-api/src/pay_api/utils/enums.py 100.00% <ø> (ø)
pay-api/src/pay_api/version.py 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

@seeker25
Copy link
Collaborator Author

seeker25 commented Sep 28, 2023

Payload to create:

POST http://localhost:5000/api/v1/reports
{
    "templateVars": {
        
    },
    "templateName": "eft_instructions",
    "reportName": "eft_instructions"
}

@seeker25 seeker25 merged commit ce9e306 into bcgov:main Sep 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants