Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps #1270

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix deps #1270

merged 1 commit into from
Oct 3, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Oct 3, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested review from Jxio and ochiu as code owners October 3, 2023 17:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1270 (0e654fa) into main (79924ce) will decrease coverage by 0.75%.
Report is 12 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   91.45%   90.71%   -0.75%     
==========================================
  Files         186      189       +3     
  Lines       11319    11439     +120     
==========================================
+ Hits        10352    10377      +25     
- Misses        967     1062      +95     
Flag Coverage Δ
bcolapi ∅ <ø> (∅)
eventlistenerqueue 81.81% <ø> (ø)
ftppoller 0.00% <ø> (?)
payadmin ∅ <ø> (?)
payapi 93.75% <100.00%> (+0.01%) ⬆️
paymentjobs 80.22% <ø> (ø)
paymentreconciliationsqueue 91.44% <ø> (ø)
reportapi 91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/models/invoice.py 100.00% <100.00%> (ø)
...api/src/pay_api/resources/v1/account_statements.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/services/statement.py 97.24% <100.00%> (+0.34%) ⬆️
pay-api/src/pay_api/utils/enums.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/version.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@seeker25 seeker25 merged commit 7ff5cfb into bcgov:main Oct 3, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants