Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17827 - initial TDI17 file retrieval setup #1274

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Oct 4, 2023

Issue #:
bcgov/entity#17827

Description of changes:

  • initial SFT poller set up for EFT File retrieval

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1274 (85092e1) into main (79924ce) will decrease coverage by 1.18%.
Report is 15 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   91.45%   90.28%   -1.18%     
==========================================
  Files         186      181       -5     
  Lines       11319    10619     -700     
==========================================
- Hits        10352     9587     -765     
- Misses        967     1032      +65     
Flag Coverage Δ
ftppoller 0.00% <0.00%> (?)
paymentreconciliationsqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/models/invoice.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/statement.py 97.61% <ø> (ø)
...api/src/pay_api/resources/v1/account_statements.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/statement.py 96.87% <ø> (-0.04%) ⬇️
pay-api/src/pay_api/utils/converter.py 100.00% <ø> (ø)
pay-api/src/pay_api/utils/enums.py 100.00% <ø> (ø)
pay-api/src/pay_api/version.py 100.00% <ø> (ø)
jobs/ftp-poller/tasks/eft_poller_ftp.py 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ochiu ochiu marked this pull request as ready for review October 4, 2023 19:02
@ochiu ochiu requested review from seeker25 and Jxio as code owners October 4, 2023 19:02
Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should probably up the version of the service?

@seeker25 seeker25 merged commit d467e71 into bcgov:main Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants