Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17836 - PAY-API Added Invoice Reference Number to the csv export #1277

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

AbrahamRostampoor
Copy link
Contributor

Issue #:
bcgov/entity#17836

Description of changes:
Invoice Reference Number is added to the PAY-API transactions csv export.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Signed-off-by: AbrahamRostampoor <Mohammadebrahim.Rostampoor@gov.bc.ca>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 changed the title 17836:PAY-API Added Invoice Reference Number to the csv export 17836 - PAY-API Added Invoice Reference Number to the csv export Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1277 (ebd57b0) into main (79924ce) will increase coverage by 0.08%.
Report is 20 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
+ Coverage   91.45%   91.54%   +0.08%     
==========================================
  Files         186      180       -6     
  Lines       11319    10592     -727     
==========================================
- Hits        10352     9696     -656     
+ Misses        967      896      -71     
Flag Coverage Δ
payapi 93.80% <100.00%> (+0.07%) ⬆️
paymentreconciliationsqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/models/invoice.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/statement.py 97.67% <100.00%> (+0.05%) ⬆️
...api/src/pay_api/resources/v1/account_statements.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/services/payment.py 97.02% <ø> (ø)
pay-api/src/pay_api/services/statement.py 97.47% <100.00%> (+0.57%) ⬆️
pay-api/src/pay_api/utils/converter.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/utils/enums.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/version.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@seeker25 seeker25 merged commit 9936f94 into bcgov:main Oct 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants