17382 - Update the Wording based on PAD Receipts

[Jxio]

Issue #:
bcgov/entity#17382

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #1281 (6da80be) into main (79924ce) will increase coverage by 0.03%.
Report is 23 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
+ Coverage   91.45%   91.48%   +0.03%     
==========================================
  Files         186      177       -9     
  Lines       11319    10478     -841     
==========================================
- Hits        10352     9586     -766     
+ Misses        967      892      -75     

Flag	Coverage Δ
paymentreconciliationsqueue	?
reportapi	91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../payment-jobs/tasks/statement_notification_task.py	32.78% <ø> (+0.96%)	⬆️
pay-api/src/pay_api/models/__init__.py	100.00% <ø> (ø)
pay-api/src/pay_api/models/invoice.py	100.00% <ø> (ø)
pay-api/src/pay_api/models/payment.py	95.87% <ø> (ø)
pay-api/src/pay_api/models/statement.py	97.61% <ø> (ø)
...api/src/pay_api/resources/v1/account_statements.py	100.00% <ø> (ø)
pay-api/src/pay_api/services/payment.py	97.02% <ø> (ø)
pay-api/src/pay_api/services/statement.py	96.87% <ø> (-0.04%)	⬇️
pay-api/src/pay_api/utils/converter.py	100.00% <ø> (ø)
pay-api/src/pay_api/utils/enums.py	100.00% <ø> (ø)
... and 1 more

... and 9 files with indirect coverage changes

[ochiu]

@Jxio I noticed in the ticket UX pin it shows "Payment Method" text and it mentions about changing the label to EFT. Is this required for your PR?

[Jxio]

bcgov/entity#17382

yes, but the payment method text is from api request payload body, I need to update other repo which send the request I think.
just checked the spot grab paymentMethodDescription: https://github.com/Jxio/sbc-pay/blob/8ad8dae155f341dfc3306d1b387d0f9a5eb2c0d4/pay-api/src/pay_api/services/receipt.py#L198C33-L198C33
it's from database, should be auto-updated when the database ready.

[ochiu]

bcgov/entity#17382

yes, but the payment method text is from api request payload body, I need to update other repo which send the request I think.

Got it! thanks for explaining.