17829 - EFT Service updates #1293
Conversation
| @@ -24,3 +28,8 @@ class EftService(DepositService): | |||
| def get_payment_method_code(self): | |||
| """Return EFT as the system code.""" | |||
| return PaymentMethod.EFT.value | |||
|
|
|||
| def create_invoice(self, payment_account: PaymentAccount, line_items: [PaymentLineItem], invoice: Invoice, | |||
There was a problem hiding this comment.
The base deposit service class already has an implementation of the required methods. I added create_invoice with a comment so it is clear that the Invoice references will be created later via the TDI17 processing.
Codecov Report
@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 91.45% 91.69% +0.24%
==========================================
Files 186 198 +12
Lines 11319 11636 +317
==========================================
+ Hits 10352 10670 +318
+ Misses 967 966 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Payments Job CI failing currently since it also needs the LD FF service update. A second PR will be submitted to update the payment job requirements.txt dependency |
* eft_short_names table * 17829 - eft feature flagging, eft short names tables * version bump * update flags service for LD 8.x
Issue #:
bcgov/entity#17829
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).