Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17303- New EFT PDF Statement Template #1296

Merged
merged 2 commits into from
Oct 30, 2023
Merged

17303- New EFT PDF Statement Template #1296

merged 2 commits into from
Oct 30, 2023

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #: 17303
bcgov/entity#17303

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1296 (baa5a34) into main (79924ce) will increase coverage by 0.04%.
Report is 27 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   91.45%   91.50%   +0.04%     
==========================================
  Files         186      177       -9     
  Lines       11319    10475     -844     
==========================================
- Hits        10352     9585     -767     
+ Misses        967      890      -77     
Flag Coverage Δ
paymentreconciliationsqueue ?
reportapi 91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../payment-jobs/tasks/statement_notification_task.py 32.78% <ø> (+0.96%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/invoice.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/payment.py 95.87% <ø> (ø)
pay-api/src/pay_api/models/statement.py 97.61% <ø> (ø)
...api/src/pay_api/resources/v1/account_statements.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/eft_service.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/flags.py 80.35% <ø> (+2.39%) ⬆️
pay-api/src/pay_api/services/payment.py 97.02% <ø> (ø)
pay-api/src/pay_api/services/payment_service.py 97.94% <ø> (ø)
... and 5 more

... and 9 files with indirect coverage changes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@seeker25 seeker25 marked this pull request as ready for review October 27, 2023 17:31
@seeker25 seeker25 requested review from Jxio and ochiu as code owners October 27, 2023 17:31
@seeker25 seeker25 merged commit 5a08a71 into main Oct 30, 2023
7 checks passed
@rodrigo-barraza rodrigo-barraza deleted the feature/17303 branch September 4, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants