Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17869 - REPORT-API - CFS Account Number Added #1309

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

AbrahamRostampoor
Copy link
Contributor

Issue #:
bcgov/entity#17869

Description of changes:

  • Added CFS Account Number to invoice.html
  • Updated the layout of invoice.html
  • Update invoice.py from PAY-API

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Signed-off-by: AbrahamRostampoor <Mohammadebrahim.Rostampoor@gov.bc.ca>
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1309 (97e4021) into main (79924ce) will increase coverage by 0.12%.
Report is 29 commits behind head on main.
The diff coverage is 98.54%.

@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
+ Coverage   91.45%   91.58%   +0.12%     
==========================================
  Files         186      181       -5     
  Lines       11319    10599     -720     
==========================================
- Hits        10352     9707     -645     
+ Misses        967      892      -75     
Flag Coverage Δ
payapi 93.82% <98.54%> (+0.09%) ⬆️
paymentreconciliationsqueue ?
reportapi 91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <ø> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py 85.18% <ø> (-0.87%) ⬇️
jobs/payment-jobs/tasks/distribution_task.py 97.70% <ø> (-0.06%) ⬇️
.../payment-jobs/tasks/statement_notification_task.py 32.78% <ø> (+0.96%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_short_names.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_transaction.py 100.00% <100.00%> (ø)
... and 15 more

... and 9 files with indirect coverage changes

Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeker25 seeker25 merged commit 95cf80f into bcgov:main Oct 27, 2023
11 checks passed
@seeker25 seeker25 changed the title 17869 - REPORT_API CFS Account Number Added 17869 - REPORT-API - CFS Account Number Added Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants