Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18395 - Implement EFT available notification #1314

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

seeker25
Copy link
Collaborator

Issue #:
bcgov/entity#18395

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1314 (bfe93be) into main (79924ce) will increase coverage by 2.31%.
Report is 34 commits behind head on main.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
+ Coverage   91.45%   93.77%   +2.31%     
==========================================
  Files         186      135      -51     
  Lines       11319     8645    -2674     
==========================================
- Hits        10352     8107    -2245     
+ Misses        967      538     -429     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 93.77% <95.23%> (+0.04%) ⬆️
paymentjobs ?
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_short_names.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_transaction.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/invoice.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/payment.py 95.87% <ø> (ø)
pay-api/src/pay_api/models/payment_account.py 97.72% <100.00%> (+0.05%) ⬆️
pay-api/src/pay_api/models/statement.py 97.67% <100.00%> (+0.05%) ⬆️
...api/src/pay_api/resources/v1/account_statements.py 100.00% <100.00%> (ø)
... and 13 more

... and 55 files with indirect coverage changes

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 marked this pull request as ready for review October 31, 2023 21:52
@seeker25 seeker25 requested review from Jxio and ochiu as code owners October 31, 2023 21:52
Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@seeker25 seeker25 temporarily deployed to dev October 31, 2023 22:11 — with GitHub Actions Inactive
@seeker25 seeker25 merged commit 38d07d9 into bcgov:main Oct 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants