Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch limit for AP refunds. #1318

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Nov 3, 2023

Issue #:
https://github.com/bcgov/entity/issues/

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested review from Jxio and ochiu as code owners November 3, 2023 21:30
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1318 (f90d147) into main (79924ce) will decrease coverage by 8.36%.
Report is 36 commits behind head on main.
The diff coverage is 92.43%.

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
- Coverage   91.45%   83.09%   -8.36%     
==========================================
  Files         186       22     -164     
  Lines       11319     1698    -9621     
==========================================
- Hits        10352     1411    -8941     
+ Misses        967      287     -680     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi ?
paymentjobs 83.09% <92.43%> (+2.87%) ⬆️
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py 85.71% <100.00%> (-0.34%) ⬇️
jobs/payment-jobs/tasks/distribution_task.py 97.75% <100.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.82% <0.00%> (+0.37%) ⬆️
jobs/payment-jobs/tasks/ap_task.py 96.07% <92.00%> (+0.03%) ⬆️
jobs/payment-jobs/tasks/statement_due_task.py 91.30% <91.30%> (ø)

... and 166 files with indirect coverage changes

@seeker25 seeker25 merged commit 9a56377 into bcgov:main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants