Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17507 - Receipt Creation when NSF Account Paid and Unlocked #1319

Closed
wants to merge 12 commits into from

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:17507
bcgov/entity#17507

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79924ce) 91.45% compared to head (b78db55) 91.09%.
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   91.45%   91.09%   -0.37%     
==========================================
  Files         186       20     -166     
  Lines       11319      292   -11027     
==========================================
- Hits        10352      266   -10086     
+ Misses        967       26     -941     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi ?
paymentjobs ?
paymentreconciliationsqueue ?
reportapi 91.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 166 files with indirect coverage changes

@@ -631,7 +633,13 @@ def _publish_queue_message(self, payload):
f'Notification to Queue failed for the Account Mailer : {payload}.',
level='error')

def _create_account_event_payload(self, event_type: str, include_pay_info: bool = False):
def _create_account_event_payload(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many params

Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seeker25
Copy link
Collaborator

Covered by #1377

@seeker25 seeker25 closed this Jan 22, 2024
@rodrigo-barraza rodrigo-barraza deleted the feature/17507 branch September 4, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants