18584 - Fix paybc changes. #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochiu
approved these changes
Nov 15, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
seeker25
commented
Nov 15, 2023
| for line in status.revenue) \ | ||
| and invoice.invoice_status_code == InvoiceStatus.REFUND_REQUESTED.value | ||
| for line in status.revenue: | ||
| if len(line.refund_data) == 0: |
There was a problem hiding this comment.
Had to put this in, otherwise using all like above fails when refund_data = []
seeker25
commented
Nov 15, 2023
| return all(line.refundglstatus == PaymentDetailsGlStatus.CMPLT | ||
| for line in status.revenue) | ||
| for line in status.revenue: | ||
| if len(line.refund_data) == 0: |
There was a problem hiding this comment.
Had to put this in, otherwise using all like above fails when refund_data = []
ochiu
approved these changes
Nov 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
- Coverage 91.45% 82.95% -8.51%
==========================================
Files 186 22 -164
Lines 11319 1701 -9618
==========================================
- Hits 10352 1411 -8941
+ Misses 967 290 -677
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcgov/entity#18584
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).