Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18767 - Add in new sequence column via model, migration and job. #1335

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

seeker25
Copy link
Collaborator

Issue #:
bcgov/entity#18767

Description of changes:
Add in new sequence column via model, migration and job.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1335 (2f5f2bf) into main (79924ce) will increase coverage by 1.94%.
Report is 53 commits behind head on main.
The diff coverage is 93.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
+ Coverage   91.45%   93.40%   +1.94%     
==========================================
  Files         186      161      -25     
  Lines       11319    10356     -963     
==========================================
- Hits        10352     9673     -679     
+ Misses        967      683     -284     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payadmin ∅ <ø> (?)
payapi 93.67% <92.13%> (-0.07%) ⬇️
paymentjobs ?
paymentreconciliationsqueue 92.42% <94.05%> (+0.97%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/base_model.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_credit.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_transaction.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/ejv_invoice_link.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/invoice.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/payment.py 95.87% <ø> (ø)
... and 43 more

... and 42 files with indirect coverage changes

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25
Copy link
Collaborator Author

Will fix the job requirements afterwards

@seeker25 seeker25 merged commit 329b4fb into bcgov:main Nov 30, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants