Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17534 - New NSF resource implementation #1341
17534 - New NSF resource implementation #1341
Changes from 29 commits
93390b7
6c7e6c0
bb0ccdd
01aa77e
40a4b47
df55123
7f663da
04742b8
e7cc660
b7c6a93
a9fa502
91e3ed5
f6c676f
456eb65
31aa3da
6cc9bdc
be2d5e2
e08b591
5d24d0d
baa28b4
5063764
dff9b98
08d62ac
13a4eb7
e2946ad
a6fbaa4
f2cebe8
848ec10
fad3b66
23c4099
4aab599
5d75820
9005132
521b252
b034d16
ae9c1de
2b50ab4
89d80bc
915cc0d
19b8a90
91785fa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why we can't use
InvoiceSearchModel
or a variation of it instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this returns a list of
cfs_accounts
, not just one - should probably be looking for the one with the highest ID / newest perhaps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not ideal, you need to choose the correct one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be debug? not info?