Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18762 - EFT automatically set statement frequency to monthly #1343

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Dec 6, 2023

Issue #:
bcgov/entity#18762

Description of changes:

  • update default statement settings for EFT payment method for account creation
  • update payment method change logic to check for EFT and ensure the correct statement frequency

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1343 (76ef0d0) into main (79924ce) will increase coverage by 2.22%.
Report is 59 commits behind head on main.
The diff coverage is 92.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
+ Coverage   91.45%   93.68%   +2.22%     
==========================================
  Files         186      138      -48     
  Lines       11319     8992    -2327     
==========================================
- Hits        10352     8424    -1928     
+ Misses        967      568     -399     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 93.68% <92.39%> (-0.06%) ⬇️
paymentjobs ?
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/base_model.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_credit.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_transaction.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/ejv_invoice_link.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/invoice.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/payment.py 95.87% <ø> (ø)
... and 29 more

... and 56 files with indirect coverage changes

@ochiu ochiu marked this pull request as ready for review December 6, 2023 17:33
@ochiu ochiu requested review from seeker25 and Jxio as code owners December 6, 2023 17:33
@seeker25 seeker25 merged commit 6f2529c into bcgov:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants