Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18924 - Fix payment_date for Disbursements, EJV, PAD, ONLINE BANKING. Fix di… #1344

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Dec 7, 2023

…sbursement_date. Fix refund_date for EJV, Disbursements.

Issue #:
bcgov/entity#18924

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

…bursement_date. Fix refund_date for EJV, Disbursements.
@seeker25 seeker25 requested review from Jxio and ochiu as code owners December 7, 2023 20:24
@@ -155,9 +155,7 @@ def update_invoice_to_refunded_or_paid(cls, invoice: InvoiceModel):
refund.gl_posted = datetime.now()
refund.save()
invoice.invoice_status_code = InvoiceStatus.REFUNDED.value
invoice.refund_date = datetime.now()
Copy link
Collaborator Author

@seeker25 seeker25 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to lose this data, as we're just shifting over GL's here.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1344 (2e1d1dd) into main (79924ce) will decrease coverage by 4.24%.
Report is 60 commits behind head on main.
The diff coverage is 94.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
- Coverage   91.45%   87.22%   -4.24%     
==========================================
  Files         186       40     -146     
  Lines       11319     3005    -8314     
==========================================
- Hits        10352     2621    -7731     
+ Misses        967      384     -583     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi ?
paymentjobs 83.34% <94.51%> (+3.12%) ⬆️
paymentreconciliationsqueue 92.43% <94.19%> (+0.98%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
jobs/payment-jobs/tasks/distribution_task.py 97.70% <100.00%> (-0.06%) ⬇️
...ayment-jobs/tasks/ejv_partner_distribution_task.py 99.17% <100.00%> (+0.03%) ⬆️
jobs/payment-jobs/tasks/ejv_payment_task.py 96.61% <100.00%> (+0.14%) ⬆️
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
...iations/src/reconciliations/cgi_reconciliations.py 93.43% <100.00%> (+0.07%) ⬆️
...ment-reconciliations/src/reconciliations/config.py 96.47% <100.00%> (+0.08%) ⬆️
...econciliations/src/reconciliations/eft/__init__.py 100.00% <100.00%> (ø)
...conciliations/src/reconciliations/eft/eft_enums.py 100.00% <100.00%> (ø)
... and 15 more

... and 157 files with indirect coverage changes

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit be0cc09 into bcgov:main Dec 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants