18924 - Fix payment_date for Disbursements, EJV, PAD, ONLINE BANKING. Fix di… #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bursement_date. Fix refund_date for EJV, Disbursements.
seeker25
commented
Dec 7, 2023
| @@ -155,9 +155,7 @@ def update_invoice_to_refunded_or_paid(cls, invoice: InvoiceModel): | |||
| refund.gl_posted = datetime.now() | |||
| refund.save() | |||
| invoice.invoice_status_code = InvoiceStatus.REFUNDED.value | |||
| invoice.refund_date = datetime.now() | |||
There was a problem hiding this comment.
Don't want to lose this data, as we're just shifting over GL's here.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
- Coverage 91.45% 87.22% -4.24%
==========================================
Files 186 40 -146
Lines 11319 3005 -8314
==========================================
- Hits 10352 2621 -7731
+ Misses 967 384 -583
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Jxio
approved these changes
Dec 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sbursement_date. Fix refund_date for EJV, Disbursements.
Issue #:
bcgov/entity#18924
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).