18955 - Change invoice status for get invoices for disbursement to include CR… #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just confirming how credited invoices work before merging |
ochiu
approved these changes
Dec 11, 2023
Jxio
approved these changes
Dec 11, 2023
|
Leaving this one for next sprint |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
- Coverage 91.45% 83.34% -8.12%
==========================================
Files 186 22 -164
Lines 11319 1723 -9596
==========================================
- Hits 10352 1436 -8916
+ Misses 967 287 -680
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…EDITED.
Issue #:
bcgov/entity#18955
Description of changes:
Invoices should go into CANCELLED, if they aren't created in CAS yet. Thus if they make it to PAID, but change into CREDITED before being disbursed - they should still be picked up by the disbursement job.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).