Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19162 - Payment Reconciliation NSF Implementation #1382

Merged
merged 14 commits into from
Jan 23, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

*Issue #:19162 *
bcgov/entity#19162

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (79924ce) 91.45% compared to head (09388cb) 91.94%.
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
+ Coverage   91.45%   91.94%   +0.48%     
==========================================
  Files         186      172      -14     
  Lines       11319    11150     -169     
==========================================
- Hits        10352    10252     -100     
+ Misses        967      898      -69     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payadmin ∅ <ø> (?)
payapi 93.64% <91.56%> (-0.10%) ⬇️
paymentjobs 83.35% <94.64%> (+3.13%) ⬆️
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
jobs/payment-jobs/tasks/distribution_task.py 97.70% <100.00%> (-0.06%) ⬇️
...ayment-jobs/tasks/ejv_partner_distribution_task.py 99.17% <100.00%> (+0.03%) ⬆️
jobs/payment-jobs/tasks/ejv_payment_task.py 96.61% <100.00%> (+0.14%) ⬆️
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
jobs/payment-jobs/tasks/statement_task.py 91.39% <100.00%> (+10.96%) ⬆️
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/custom_query.py 100.00% <100.00%> (ø)
... and 53 more

... and 32 files with indirect coverage changes

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seeker25 seeker25 marked this pull request as ready for review January 23, 2024 19:52
@seeker25 seeker25 merged commit 5831aae into main Jan 23, 2024
20 of 22 checks passed
@rodrigo-barraza rodrigo-barraza deleted the feature/19162-payment-reconciliation-refactoring branch September 4, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants