17534 - nsf tweaks #1385
17534 - nsf tweaks #1385
Conversation
Adding cfs_account_id field to non_sufficient_funds, and adding the CSV reconciliation description to non_sufficient_funds
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
+ Coverage 91.45% 91.98% +0.52%
==========================================
Files 186 190 +4
Lines 11319 12437 +1118
==========================================
+ Hits 10352 11440 +1088
- Misses 967 997 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -55,15 +57,16 @@ class NonSufficientFundsSchema: # pylint: disable=too-few-public-methods | |||
| """Used to search for NSF records.""" | |||
|
|
|||
| id: int | |||
| description: str | |||
| cfs_account: int | |||
| invoice_id: int | |||
There was a problem hiding this comment.
We could do away with it if there is no need for OPS to have this information about a specific invoice, and we're currently still using it on the DB queries (but could query around it).
There was a problem hiding this comment.
I think it's a bit confusing to leave it in there (or at least as invoice_id), because the NSF pertains to multiple invoice ids (grouped up by the invoice_number) and you're not creating multiple rows.. Maybe we could use a better name for it instead?
nsf_fee_invoice_id? that way it's distinct from the other invoice_ids that are NSF
|
Adding cfs_account_id field to non_sufficient_funds, and adding the CSV reconciliation description to non_sufficient_funds
Issue #:
https://github.com/bcgov/entity/issues/
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).