Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync db models with migration #1388

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Sync db models with migration #1388

merged 1 commit into from
Jan 25, 2024

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Jan 25, 2024

Description of changes:

  • migration script fixes to sync with model definitions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@ochiu ochiu marked this pull request as ready for review January 25, 2024 18:29
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (79924ce) 91.45% compared to head (1b3f16a) 91.63%.
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
+ Coverage   91.45%   91.63%   +0.17%     
==========================================
  Files         186       23     -163     
  Lines       11319     1387    -9932     
==========================================
- Hits        10352     1271    -9081     
+ Misses        967      116     -851     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payapi ?
paymentjobs ?
paymentreconciliationsqueue 92.38% <93.90%> (+0.93%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ices/events-listener/src/events_listener/config.py 93.75% <100.00%> (+0.13%) ⬆️
...iations/src/reconciliations/cgi_reconciliations.py 93.43% <100.00%> (+0.07%) ⬆️
...ment-reconciliations/src/reconciliations/config.py 96.47% <100.00%> (+0.08%) ⬆️
...econciliations/src/reconciliations/eft/__init__.py 100.00% <100.00%> (ø)
...conciliations/src/reconciliations/eft/eft_enums.py 100.00% <100.00%> (ø)
...onciliations/src/reconciliations/eft/eft_errors.py 100.00% <100.00%> (ø)
...onciliations/src/reconciliations/eft/eft_header.py 100.00% <100.00%> (ø)
...iations/src/reconciliations/eft/eft_parse_error.py 100.00% <100.00%> (ø)
...nciliations/src/reconciliations/eft/eft_trailer.py 100.00% <100.00%> (ø)
...yment-reconciliations/src/reconciliations/enums.py 100.00% <100.00%> (ø)
... and 6 more

... and 172 files with indirect coverage changes

@ochiu ochiu merged commit 9fbe87c into bcgov:main Jan 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants