19336 - EFT Payment details #1389
Conversation
- EFT Short name search updates - EFT transactions by short name route
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 91.45% 92.12% +0.67%
==========================================
Files 186 192 +6
Lines 11319 12693 +1374
==========================================
+ Hits 10352 11694 +1342
- Misses 967 999 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| deposit_date=string_to_date(deposit_date) if deposit_date else None, | ||
| deposit_amount=Decimal(deposit_amount) * Decimal(100) if deposit_amount else None, | ||
| short_name=short_name, | ||
| transaction_date=string_to_date(transaction_date) if transaction_date else None, |
There was a problem hiding this comment.
change string_to_date to return None?
There was a problem hiding this comment.
This was an existing utility function I re-used. I will take a look at some of the existing usages and see if it impacts it.
There was a problem hiding this comment.
it would throw a runtime error if None was put in there fairly certain, I don't think you'd be impacting anything
RoutingSlipDate would fail the schema on the API endpoint before hitting that line I think
paymentDate they did the same thing
There was a problem hiding this comment.
Updated utils function and any usages.
| EFTTransactionModel.deposit_date, | ||
| EFTTransactionModel.deposit_amount_cents, | ||
| EFTTransactionModel.short_name_id, | ||
| func.row_number().over(partition_by=EFTTransactionModel.short_name_id, |
There was a problem hiding this comment.
cool haven't see partition by much
|
Issue #:
bcgov/entity#19336
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).