Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19336 - update eft transactions TDI17 processing #1391

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Jan 30, 2024

Issue #:
bcgov/entity#19336

Description of changes:

  • update TDI17 processing to populate deposit_date and transaction_date

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@ochiu ochiu requested review from seeker25 and Jxio as code owners January 30, 2024 21:00
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (79924ce) 91.45% compared to head (e40519b) 92.39%.
Report is 89 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   91.45%   92.39%   +0.94%     
==========================================
  Files         186       18     -168     
  Lines       11319     1289   -10030     
==========================================
- Hits        10352     1191    -9161     
+ Misses        967       98     -869     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi ?
paymentjobs ?
paymentreconciliationsqueue 92.39% <93.93%> (+0.95%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...iations/src/reconciliations/cgi_reconciliations.py 93.43% <100.00%> (+0.07%) ⬆️
...ment-reconciliations/src/reconciliations/config.py 96.47% <100.00%> (+0.08%) ⬆️
...econciliations/src/reconciliations/eft/__init__.py 100.00% <100.00%> (ø)
...conciliations/src/reconciliations/eft/eft_enums.py 100.00% <100.00%> (ø)
...onciliations/src/reconciliations/eft/eft_errors.py 100.00% <100.00%> (ø)
...onciliations/src/reconciliations/eft/eft_header.py 100.00% <100.00%> (ø)
...iations/src/reconciliations/eft/eft_parse_error.py 100.00% <100.00%> (ø)
...nciliations/src/reconciliations/eft/eft_trailer.py 100.00% <100.00%> (ø)
...yment-reconciliations/src/reconciliations/enums.py 100.00% <100.00%> (ø)
...ment-reconciliations/src/reconciliations/worker.py 88.09% <100.00%> (+1.25%) ⬆️
... and 5 more

... and 177 files with indirect coverage changes

@ochiu ochiu merged commit 3954c24 into bcgov:main Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants