19334 - Adding Find EFT Accounts Endpoint #1392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit ef9265c5a623edc516843c8c84237f19af033e78 Merge: 440bc022 3954c24 Author: Rodrigo Barraza <hello@rod.dev> Date: Tue Jan 30 14:11:01 2024 -0800 Merge branch 'main' into feature/19934 commit 440bc02284e78881bf0b366a289cb2ae99137e64 Author: Rodrigo Barraza <hello@rod.dev> Date: Tue Jan 30 14:10:24 2024 -0800 Find Eft accounts
rodrigo-barraza
requested review from
seeker25,
Jxio and
ochiu
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
+ Coverage 91.45% 92.10% +0.64%
==========================================
Files 186 193 +7
Lines 11319 12732 +1413
==========================================
+ Hits 10352 11727 +1375
- Misses 967 1005 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ochiu
reviewed
Jan 31, 2024
| @@ -652,6 +654,34 @@ def find_by_id(cls, account_id: int): | |||
| account._dao = PaymentAccountModel.find_by_id(account_id) # pylint: disable=protected-access | |||
| return account | |||
|
|
|||
| @classmethod | |||
| def find_eft_accounts(cls, page: int, limit: int): | |||
There was a problem hiding this comment.
find_unlinked_eft_accounts or have the state as a filter param?
There was a problem hiding this comment.
Yup need this otherwise pagination wont work that well for the two screens
|
seeker25
reviewed
Feb 1, 2024
| query = query.order_by(PaymentAccountModel.id) | ||
| pagination = query.paginate(per_page=eft_accounts_search.limit, page=eft_accounts_search.page) | ||
|
|
||
| total = pagination.total |
There was a problem hiding this comment.
'total': pagination.total
eft_accounts_list = [PaymentAccountSearchModel.from_row(eft_account) for eft_account in pagination.items]
seeker25
reviewed
Feb 1, 2024
|
|
||
| eft_accounts_list = [PaymentAccountSearchModel.from_row(eft_account) for eft_account in eft_accounts] | ||
| converter = Converter() | ||
| eft_accounts_list = converter.unstructure(eft_accounts_list) |
There was a problem hiding this comment.
Converter().unstructure(eft_accounts_list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:19334
bcgov/entity#19334
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).