Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16467 - NSF Calculation Fixes and PDF Download #1396

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:16467
https://github.com/bcgov/entity/issues/

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (79924ce) 91.45% compared to head (c521373) 93.71%.
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   91.45%   93.71%   +2.25%     
==========================================
  Files         186      146      -40     
  Lines       11319     9463    -1856     
==========================================
- Hits        10352     8868    -1484     
+ Misses        967      595     -372     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 93.71% <92.26%> (-0.03%) ⬇️
paymentjobs ?
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/custom_query.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/db.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_credit.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_credit_invoice_link.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_gl_transfers.py 100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_transaction.py 100.00% <100.00%> (ø)
... and 43 more

... and 58 files with indirect coverage changes

@seeker25 seeker25 merged commit 755014f into main Feb 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants