Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19330 eft shortname date range fix #1400

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Feb 5, 2024

Issue #:
bcgov/entity#19330

Description of changes:

  • fix date range filter to and and_ clause

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (79924ce) 91.45% compared to head (b6ebd04) 84.32%.
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
- Coverage   91.45%   84.32%   -7.13%     
==========================================
  Files         186       28     -158     
  Lines       11319     1959    -9360     
==========================================
- Hits        10352     1652    -8700     
+ Misses        967      307     -660     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payapi ?
paymentjobs 84.45% <96.36%> (+4.23%) ⬆️
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
jobs/payment-jobs/tasks/distribution_task.py 97.70% <100.00%> (-0.06%) ⬇️
...ayment-jobs/tasks/ejv_partner_distribution_task.py 99.17% <100.00%> (+0.03%) ⬆️
jobs/payment-jobs/tasks/ejv_payment_task.py 96.61% <100.00%> (+0.14%) ⬆️
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
jobs/payment-jobs/tasks/statement_task.py 91.39% <100.00%> (+10.96%) ⬆️
...ices/events-listener/src/events_listener/config.py 93.75% <100.00%> (+0.13%) ⬆️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 71.03% <0.00%> (-1.42%) ⬇️
jobs/payment-jobs/tasks/ap_task.py 96.07% <92.00%> (+0.03%) ⬆️
... and 3 more

... and 160 files with indirect coverage changes

@ochiu ochiu merged commit 352b850 into bcgov:main Feb 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants