Fix the description field, it's incorrect #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-barraza
approved these changes
Feb 22, 2024
seeker25
commented
Feb 22, 2024
| @@ -56,7 +56,7 @@ class Column(Enum): | |||
| TARGET_TXN_OUTSTANDING = 'Target Transaction Outstanding Amount' | |||
| TARGET_TXN_STATUS = 'Target transaction status' | |||
| REVERSAL_REASON_CODE = 'Reversal Reason code' | |||
| REVERSAL_REASON_DESC = 'Reversal reason description' | |||
| REVERSAL_REASON_DESC = 'Reversal reason desc' | |||
There was a problem hiding this comment.
from PROD:
'reversal reason desc': 'Edit Reject'}
|
ochiu
approved these changes
Feb 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
+ Coverage 91.45% 92.26% +0.80%
==========================================
Files 186 18 -168
Lines 11319 1293 -10026
==========================================
- Hits 10352 1193 -9159
+ Misses 967 100 -867
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).