Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21472 - update sbc-pay version for release 1.21.0 #1546

Merged

Conversation

avni-work
Copy link
Collaborator

Issue #:
https://github.com/bcgov/entity/issues/

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Signed-off-by: Avni Salhotra <avni.salhotra@gov.bc.ca>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (79924ce) to head (79c1447).
Report is 154 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
+ Coverage   91.45%   93.38%   +1.92%     
==========================================
  Files         186      143      -43     
  Lines       11319     9567    -1752     
==========================================
- Hits        10352     8934    -1418     
+ Misses        967      633     -334     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 93.38% <100.00%> (-0.36%) ⬇️
paymentjobs ?
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/version.py 100.00% <100.00%> (ø)

... and 181 files with indirect coverage changes

Copy link
Collaborator

@rodrigo-barraza rodrigo-barraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeker25 seeker25 merged commit c47847e into bcgov:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants