20719- Interim Statements Settings Fix #1584
Conversation
ochiu
requested review from
seeker25,
Jxio,
rodrigo-barraza and
avni-work
as code owners
| @@ -156,6 +156,7 @@ def run(job_name, argument=None): | |||
| if __name__ == "__main__": | |||
| print('----------------------------Scheduler Ran With Argument--', sys.argv[1]) | |||
| if (len(sys.argv) > 2): | |||
| run(sys.argv[1], sys.argv[2]) | |||
| params = sys.argv[2:len(sys.argv)] | |||
| run(sys.argv[1], params) | |||
There was a problem hiding this comment.
Update to allow any number of parameters to be passed in when running a job.
| """Generate statements. | ||
|
|
||
| Steps: | ||
| 1. Get all payment accounts and it's active statement settings. | ||
| """ | ||
| date_override = arguments[0] if arguments and len(arguments) > 0 else None | ||
| auth_account_override = arguments[1] if arguments and len(arguments) > 1 else None |
There was a problem hiding this comment.
allow a specific account number to be filtered on. This allows us to generate a monthly statement using the interim statement settings before the month is up without affecting other accounts
There was a problem hiding this comment.
Great idea, I was thinking about this the other day, when I had to regenerate statements for a client
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 91.45% 82.62% -8.84%
==========================================
Files 186 23 -163
Lines 11319 1974 -9345
==========================================
- Hits 10352 1631 -8721
+ Misses 967 343 -624
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -322,6 +321,114 @@ def test_get_monthly_interim_statement(session, admin_users_mock): | |||
| assert monthly_invoices[0].invoice_id == monthly_invoice.id | |||
|
|
|||
|
|
|||
| def test_interim_statement_settings_eft(db, session, admin_users_mock): | |||
There was a problem hiding this comment.
Ken found some anomalies which was more prevalent when swapping payment methods within the same day.
Fix was for this issue and added a test.
Issue #:
bcgov/entity#20719
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).