22672 - Fix missing Approved invoices on get_invoices_owing_amount #1682
Conversation
|
Thanks Jia, can we add / expand on an existing test to check on this invoices amount owing please? |
| @@ -248,6 +248,7 @@ def get_invoices_owing_amount(auth_account_id: str): | |||
| .filter(InvoiceModel.invoice_status_code.in_((InvoiceStatus.SETTLEMENT_SCHEDULED.value, | |||
There was a problem hiding this comment.
Do we need an EFT filter here?
There was a problem hiding this comment.
yes, let's do that to make this more clean/safe. Only EFT uses the statement summary right now. We can consider expanding this by adding a payment method query parameter in the future if needed.
| @@ -248,6 +248,7 @@ def get_invoices_owing_amount(auth_account_id: str): | |||
| .filter(InvoiceModel.invoice_status_code.in_((InvoiceStatus.SETTLEMENT_SCHEDULED.value, | |||
| InvoiceStatus.PARTIAL.value, | |||
| InvoiceStatus.CREATED.value, | |||
There was a problem hiding this comment.
I think we need to take out CREATED, CREATED applies to NSF invoices and other payment methods.. EFT doesn't have CREATED anymore
There was a problem hiding this comment.
The parent function doesn't have CREATED:
There was a problem hiding this comment.
yeah I think so, taking out
seeker25
changed the title
|
Associated this to the correct ticket 22672 |
Issue #:
bcgov/entity#22672
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).