Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22655 - Wire in reverse_invoice for consolidated invoices #1702

Merged
merged 66 commits into from
Aug 30, 2024
Merged

22655 - Wire in reverse_invoice for consolidated invoices #1702

merged 66 commits into from
Aug 30, 2024

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Aug 22, 2024 •
edited
Loading

Issue #:
bcgov/entity#22655

Flows:

  1. EFT Client is overdue, they never navigate to the consolidation payments screen (NSF lock flow and don't hit the next button on credit card) - no cfs_invoice is created for consolidated invoice and no invoice_reference is created. They pay by regular EFT and it works.
  2. EFT Client is overdue, pay by credit card, creates and pays consolidated invoices and reverses the "regular" invoice, this should unlock the users.
  3. EFT Client is overdue they start the pay by credit card which creates a consolidated invoice, they eventually pay by EFT instead.
    The job is smart enough to realize they had a consolidated invoice, reverses that and completes payment on the "regular" invoice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 changed the title 22655 - Wire in reverse_invoice for consolidated invoices plus unit test 22655 - Wire in reverse_invoice for consolidated invoices Aug 22, 2024
seeker25
seeker25 commented Aug 30, 2024
View reviewed changes
pay-api/tests/unit/services/test_statement.py
@@ -227,8 +227,9 @@ def test_get_interim_statement_change_away_from_eft(session, admin_users_mock):
invoice_create_date = localize_date(datetime(2023, 10, 9, 12, 0))
monthly_invoice = factory_invoice(payment_account=account, created_on=invoice_create_date,
Copy link
Collaborator Author

@seeker25 seeker25 Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this was correct before?

Can't have approved EFT and switch to PAD without balance check?

@seeker25 seeker25 marked this pull request as ready for review August 30, 2024 02:17
ochiu
ochiu approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go to me. Thanks

@seeker25 seeker25 merged commit cd6c39f into bcgov:main Aug 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochiu ochiu ochiu approved these changes

@Jxio Jxio Awaiting requested review from Jxio Jxio is a code owner

@rodrigo-barraza rodrigo-barraza Awaiting requested review from rodrigo-barraza rodrigo-barraza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seeker25 @ochiu