Clean out wire and unused code #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochiu
reviewed
Aug 27, 2024
| @@ -492,7 +492,16 @@ def add_nsf_adjustment(cls, cfs_account: CfsAccountModel, inv_number: str, amoun | |||
|
|
|||
| @classmethod | |||
| def adjust_invoice(cls, cfs_account: CfsAccountModel, inv_number: str, amount=0.0, adjustment_lines=None): | |||
| """Add adjustment to the invoice.""" | |||
| """Add adjustment to the invoice. | |||
There was a problem hiding this comment.
We might need to use adjust invoice.. because we can adjust it for a reversal and adjust it back if we need to use the invoice again. Reverse invoice, doesn't seem to be able to go backwards unless we can edit credit memos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).