Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22263 - EFT Refund AP Job Implementation #1719

Merged
merged 46 commits into from
Oct 2, 2024
Merged

22263 - EFT Refund AP Job Implementation #1719

merged 46 commits into from
Oct 2, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:
bcgov/entity#22263

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@rodrigo-barraza rodrigo-barraza marked this pull request as ready for review September 4, 2024 15:28
@seeker25
Copy link
Collaborator

seeker25 commented Sep 5, 2024 •
edited
Loading

You'll need to:

  1. Grab an existing AP file and figure out the bits that are specific to routing slip refunds that need to be changed into EFT refunds, confirm with finance the fields that should go in there

  2. Take these secrets, provide them to Jia or myself we can put them in 1pass

  3. After you've done the above, grab the secrets from TEST and run locally and submit a file on TEST and make sure it returns back 0000 (takes a day typically to get feedback)

Note: some of the GL's that are on PROD might not work on TEST, so look at the existing secrets in TEST for AP and compare - so if the GL's aren't correct on TEST, not a huge deal

@ochiu ochiu mentioned this pull request Sep 13, 2024
Merged
seeker25
seeker25 reviewed Sep 27, 2024
View reviewed changes
pay-api/src/pay_api/models/eft_refund.py
@@ -58,6 +59,8 @@ class EFTRefund(Audit):
comment = db.Column(db.String(), nullable=False)
decline_reason = db.Column(db.String(), nullable=True)
created_by = db.Column('created_by', db.String(100), nullable=True)
created_on = db.Column('created_on', db.DateTime, nullable=False, default=lambda: datetime.now(tz=timezone.utc))
disbursement_status_code = db.Column(db.String(20), ForeignKey('disbursement_status_codes.code'), nullable=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I'll clean this one out later

@rodrigo-barraza rodrigo-barraza merged commit 83380c1 into main Oct 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeker25 seeker25 seeker25 approved these changes

@Jxio Jxio Awaiting requested review from Jxio Jxio is a code owner

@ochiu ochiu Awaiting requested review from ochiu ochiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigo-barraza @seeker25 @ochiu