22391 - EFT Multi Account under payment #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- short name service refactor for eft credit balance to avoid cyclic issue
ochiu
commented
Sep 10, 2024
| @@ -75,16 +75,6 @@ class EFTShortnamesSearch: # pylint: disable=too-many-instance-attributes | |||
| class EFTShortnames: # pylint: disable=too-many-instance-attributes | |||
| """Service to manage EFT short name model operations.""" | |||
|
|
|||
| @staticmethod | |||
| def get_eft_credit_balance(short_name_id: int) -> Decimal: | |||
There was a problem hiding this comment.
Moved to model due to cyclic issues with statement service.
As previously discussed we will be refactoring this service to split it out later. Depending on the query some of these functions are probably better in the model.
ochiu
commented
Sep 10, 2024
ochiu
commented
Sep 10, 2024
| InvoiceModel.invoice_status_code.in_([InvoiceStatus.APPROVED.value, | ||
| InvoiceStatus.OVERDUE.value]))) | ||
| .filter( | ||
| InvoiceModel.payment_account_id.in_(accounts_query)).subquery()) |
There was a problem hiding this comment.
Tested against several large accounts for this in clause, at once. Results came back in about 100ms
|
Hold off for release |
|
Working on a test to set up multi account link to trigger under payment flag. |
seeker25
reviewed
Sep 11, 2024
| @classmethod | ||
| def find_by_short_name_id(cls, short_name_id: int): | ||
| def find_by_short_name_id(cls, short_name_id: int) -> Self: |
There was a problem hiding this comment.
cool I think I was using futures, but this looks better
seeker25
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#22391
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).