Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24432 - Bottom of EFT statement dynamic amount owing should be immutable #1829

Merged
merged 20 commits into from
Nov 20, 2024

Conversation

seeker25
Copy link
Collaborator

Issue #:
bcgov/entity#24432

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 marked this pull request as ready for review November 20, 2024 21:27
Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Glad we were able to use dates to calculate on the fly and the backwards compatibility on non EFT statement calculations were kept intact.

@seeker25 seeker25 merged commit f7deab0 into main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants