More performance enhancements #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
…ment account id, optimizer doesn't seem to be working right
…we have, add some extras the database was having to grab.
|
@Jxio Looks like you're right about the counts (this is executed on production in OCP): Probably need to talk to Ethan and John about removing them if they want some serious performance. With count: Without count: |
seeker25
commented
Dec 8, 2024
| @@ -320,7 +331,7 @@ def search_purchase_history( # noqa:E501; pylint:disable=too-many-arguments, to | |||
| count_future = executor.submit(cls.get_count, auth_account_id, search_filter) | |||
| sub_query = cls.generate_subquery(auth_account_id, search_filter, limit, page) | |||
| query = query.filter(Invoice.id.in_(sub_query.subquery().select())).order_by(Invoice.id.desc()) | |||
| result_future = executor.submit(db.session.query(Invoice).from_statement(query).all) | |||
There was a problem hiding this comment.
This was no good, would get rid of all of nice load_only all the rows would have to be reloaded at serialization
seeker25
commented
Dec 8, 2024
| .outerjoin(PaymentLineItem, PaymentLineItem.invoice_id == Invoice.id) | ||
| .outerjoin( | ||
| db.session.query(Invoice) | ||
| .join(PaymentAccount, Invoice.payment_account_id == PaymentAccount.id) |
There was a problem hiding this comment.
Joins make sense for these, they will always occur
|
For Monday: Needs quick side by side comparison |
Jxio
approved these changes
Dec 9, 2024
rodrigo-barraza
approved these changes
Dec 9, 2024
ochiu
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).