Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minZoom and maxZoom properties when initializing the leaflet map #248

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add minZoom and maxZoom properties when initializing the leaflet map #248

merged 1 commit into from
Sep 14, 2022

Conversation

dgboss
Copy link
Contributor

@dgboss dgboss commented Sep 14, 2022

The change was introduced at line 829, character 1088.

michaelpnelson
michaelpnelson approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@michaelpnelson michaelpnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the freeze when the Identify tool is active and we click on a route, and confirmed that this change addresses the freeze. The zoom values seem OK to me.

@dgboss dgboss merged commit 914acc3 into develop Sep 14, 2022
@dgboss dgboss deleted the maxZoom branch September 14, 2022 22:48
@dgboss dgboss restored the maxZoom branch September 14, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpnelson michaelpnelson michaelpnelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgboss @michaelpnelson